Skip to content

feat: implement multi version K8s build matrix and docker arguments (#27)#29

Open
danishdynamic wants to merge 2 commits into52North:mainfrom
danishdynamic:feat/k8s-matrix-build
Open

feat: implement multi version K8s build matrix and docker arguments (#27)#29
danishdynamic wants to merge 2 commits into52North:mainfrom
danishdynamic:feat/k8s-matrix-build

Conversation

@danishdynamic
Copy link
Copy Markdown

@danishdynamic danishdynamic commented Apr 10, 2026

Description:

This PR improves the build pipeline to support different kubernetes versions by introducing a build matrix and configuring both build time and run time versioning.

Key Changes:

  • Multi version support: Added a strategy.matrix to the github actions workflow to build images for k8s versions 1.33, 1.34, and 1.35 in parallel.

  • Dynamic tagging: Updated docker tags to include the k8s version (e.g., k8s-1.35), ensuring clear identification on docker hub.

  • Dockerfile configuration:

  • Added ARG K8S_VERSION to accept the version from the CI matrix.

  • Added ENV K8S_VERSION to make the cluster version available to the pygeoapi-k8s-manager at runtime.

  • Tooling: Integrated uv in the pipeline for faster, locked dependency management.

@danishdynamic danishdynamic mentioned this pull request Apr 10, 2026
Open
@EHJ-52n
Copy link
Copy Markdown
Member

EHJ-52n commented Apr 17, 2026

Please keep the pygeoapi-manager version in the tag, e.g. 52north/pygeoapi-k8s-manager:0.24-1.34. The 0.24 comes from the git tag v0.24 for example.

@EHJ-52n
Copy link
Copy Markdown
Member

EHJ-52n commented Apr 17, 2026

Furthermore, you should also consider the pyproject.toml, as it also manages the Kubernetes version.

@danishdynamic
Copy link
Copy Markdown
Author

danishdynamic commented Apr 21, 2026

Hi @EHJ-52n

I’ve updated the PR to address your feedback:

  • Tagging Convention: Images are now tagged using the ${VERSION}-${K8S_VERSION} format (e.g., 0.24-1.34). I've updated the logic to strip the v prefix from git tags to match your requirements.

  • Dependency Syncing: I added a sed step in the workflow to dynamically update the kubernetes version in pyproject.toml to match the matrix version before the build.

  • Verification: I verified locally that uv sync correctly resolves the environment when the pyproject.toml is updated to higher Kubernetes versions (tested up to v34).

The CI matrix is now running correctly with these changes. Looking forward to your review!

Addresses #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danishdynamic @EHJ-52n